SI
SI
discoversearch

We've detected that you're using an ad content blocking browser plug-in or feature. Ads provide a critical source of revenue to the continued operation of Silicon Investor.  We ask that you disable ad blocking while on Silicon Investor in the best interests of our community.  If you are not using an ad blocker but are still receiving this message, make sure your browser's tracking protection is set to the 'standard' level.
Politics : Formerly About Advanced Micro Devices

 Public ReplyPrvt ReplyMark as Last ReadFilePrevious 10Next 10PreviousNext  
To: Bilow who wrote (749348)10/25/2013 8:11:04 PM
From: Tenchusatsu  Read Replies (1) of 1573925
 
Carl and SilentZ, there are two schools of thought with regard to removing legacy code.

One is to comment it out, because you won't know in the short term exactly how your changes will affect anyone else. Therefore if you need to restore the code that you removed, it's as easy as uncommenting it.

The other is to just delete it and rely on whatever revision control system you have to save the old code. If you or someone else wants to restore the old code, you use the system and run a "diff" on the versions.

The latter method leads to cleaner, easier to read code, but it can be hard to tell at a glance what was removed. The former method will leave all that old code in the file so that you or future editors of that file can see right there how things used to be done.

As to that warning in the code, it's relatively benign, but it's kind of odd that someone put that statement in there in the first place. I mean, it's one thing to neglect reasonable privacy safeguards, but it's another when someone flat out intended on not implementing them in the first place.

Tenchusatsu
Report TOU ViolationShare This Post
 Public ReplyPrvt ReplyMark as Last ReadFilePrevious 10Next 10PreviousNext